cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Steven Gill <stevengil...@gmail.com>
Subject Re: [VOTE] 3.9.1 iOS Release
Date Mon, 10 Aug 2015 21:41:40 GMT
I think a better long term solution would be to move bin/node_modules into
root node_modules and include them as bundleDependencies. But I won't do
that for now as it probably involves updating references.

I will do your suggestion and retag + start another vote thread.



On Sat, Aug 8, 2015 at 5:35 AM, Carlos Santana <csantana23@gmail.com> wrote:

> I got some progress,
> I think the fix is, Steve give it a try to see if you get same results
>
> node -v
> v0.12.7
> npm -v
> 2.11.3
>
> cd cordova-ios
> git checkout 3.9.1
> rm -rf node_modules
> edit package.son
> move all from dependencies to devDependencies
> remove dependencies
> remove all bundledDependencies
>
> don't worry about removing all bundleDepencies, they are already there in
> bin/node_modules/ in source control git (i.e. I'm still not happy with this
> but it works)
>
> this will leave only devDependencies
> "devDependencies": { "jshint": "^2.6.0", "uncrustify": "^0.6.1",
> "jasmine-node": "~1", "shelljs": "^0.2.6", "coffee-script": "^1.7.1",
> "nodeunit": "^0.8.7" }
>
> npm install
> npm test
>
> Run coho as normal and create tgz
>
>
> the reason is included is because when we run npm install everything in
> bundleDependencies get's installed in node_modules
> then when npm pack runs it packs bundleDependencies that are present in
> dependencies in this case shelljs
>
>
>
> On Sat, Aug 8, 2015 at 7:47 AM Carlos Santana <csantana23@gmail.com>
> wrote:
>
> > OK the tag doesn't show on github. but I was using maybe wrong apache
> git,
> > I guess this is some type of mirror//stage that is the one that pushes to
> > github.
> > git://git.apache.org/cordova-ios.git
> >
> > then I switched to the correct normal one
> > https://git-wip-us.apache.org/repos/asf/cordova-ios.git
> > and now I see the 3.9.1 WTF?
> >
> > Anyway I was lazy and use the apache git url from github :-)
> >
> > Maybe we need to open a INFRA to get the tags populated to github?
> >
> > keep reading if you want to see my WTF moment :-)
> >
> > \cordova-ios:(master)$ git remote -v
> > origin git://git.apache.org/cordova-ios.git (fetch)
> > origin git://git.apache.org/cordova-ios.git (push)
> > \cordova-ios:(master)$ git tag | grep 3.9
> > 3.9.0
> > \cordova-ios:(master)$ git fetch
> > \cordova-ios:(master)$ git tag | grep 3.9
> > 3.9.0
> >
> > \cordova-ios:(master)$ git remote -v
> > origin https://git-wip-us.apache.org/repos/asf/cordova-ios.git (fetch)
> > origin https://git-wip-us.apache.org/repos/asf/cordova-ios.git (push)
> > \cordova-ios:(master)$ git tag | grep 3.9
> > 3.9.0
> > 3.9.1
> >
> >
> >
> >
> > On Sat, Aug 8, 2015 at 1:10 AM Steven Gill <stevengill97@gmail.com>
> wrote:
> >
> >> The tag did get pushed.
> >> https://git-wip-us.apache.org/repos/asf?p=cordova-ios.git;a=summary.
> For
> >> some reason it hasn't gotten mirrored to github yet.
> >>
> >> I'm not sure what is going on here in regards to the node_modules
> >> directory. Even when I did rm -rf node_modules + npm install and then
> >> create archive, it is being included in the tgz. Looks like it might be
> >> happening because it is listed as a bundled dependency. I'll have to
> look
> >> into it more.
> >>
> >>
> >> On Fri, Aug 7, 2015 at 5:40 PM, Carlos Santana <csantana23@gmail.com>
> >> wrote:
> >>
> >> > -1
> >> >
> >> >
> >> > tag 3.9.1 is not push but I was able to get far in verification using
> >> > hash d98128682c3cd6a9f51948c7cd6c0d6add2eab44
> >> >
> >> > But I got block when trying to create-archive
> >> >
> >> > I was not able to reproduce tgz using a clean git clone and using $
> >> > ./cordova-coho/coho create-archive -r ios --dest testiosrelease/ --tag
> >> > d98128682c3cd6a9f51948c7cd6c0d6add2eab44
> >> >
> >> > the tgz in cordova-ios-3.9.1.tgz
> >> > <
> >> >
> >>
> https://dist.apache.org/repos/dist/dev/cordova/CB-9463/cordova-ios-3.9.1.tgz
> >> > >
> >> >
> >> > Has an extra "node_modules" at the root (node_modules/shelljs/) this
> is
> >> not
> >> > present in the repo, and is not present in older tgz 3.9.0 and 3.8.0
> >> > cordova-ios-3.9.0.tgz
> >> > <
> http://archive.apache.org/dist/cordova/platforms/cordova-ios-3.9.0.tgz
> >> >
> >> > cordova-ios-3.8.0.tgz
> >> > <
> http://archive.apache.org/dist/cordova/platforms/cordova-ios-3.8.0.tgz
> >> >
> >> >
> >> > Not sure if these deserves a -1 but Steve, if you do a clean git clone
> >> from
> >> > apache git cordova-ios and create-archive you should not get this
> >> > "node_modules" at the root of the package tgz
> >> >
> >> > if you do then I did a step trying to create-archive
> >> >
> >> >
> >> >
> >> >
> >> > On Fri, Aug 7, 2015 at 5:30 PM Steven Gill <stevengill97@gmail.com>
> >> wrote:
> >> >
> >> > > bump
> >> > >
> >> > > On Wed, Aug 5, 2015 at 3:59 PM, Steven Gill <stevengill97@gmail.com
> >
> >> > > wrote:
> >> > >
> >> > > > Please review and vote on this 3.9.1 iOS Release
> >> > > > by replying to this email (and keep discussion on the DISCUSS
> >> Upcoming
> >> > > Releases thread)
> >> > > >
> >> > > > Release issue: https://issues.apache.org/jira/browse/CB-9463
> >> > > >
> >> > > > The archive has been published to dist/dev:
> >> > > https://dist.apache.org/repos/dist/dev/cordova/CB-9463
> >> > > >
> >> > > > The package was published from its corresponding git tag:
> >> > > > cordova-ios: 3.9.1 (d98128682c)
> >> > > >
> >> > > > Note that you can test it out via:
> >> > > >
> >> > > >     cordova platform add
> >> https://github.com/apache/cordova-ios#3.9.1
> >> > > >
> >> > > > Upon a successful vote I will upload the archive to dist/, publish
> >> it
> >> > to
> >> > > NPM, and announce it.
> >> > > >
> >> > > > Voting guidelines:
> >> > >
> >> >
> >>
> https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md
> >> > > >
> >> > > > Voting will go on for a minimum of 48 hours.
> >> > > >
> >> > > > I vote +1:
> >> > > > * Ran coho audit-license-headers over the relevant repos
> >> > > > * Ran coho check-license to ensure all dependencies and
> >> subdependencies
> >> > > have Apache-compatible licenses
> >> > > > * Updated ios@3.8.0 project to 3.9.1 and ensured that it built.
> >> > > >
> >> > > >
> >> > >
> >> >
> >>
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message