cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vladimir-kotikov <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: CB-9354 Fix array merging with complex i...
Date Mon, 31 Aug 2015 14:57:31 GMT
Github user vladimir-kotikov commented on the pull request:

    https://github.com/apache/cordova-lib/pull/256#issuecomment-136397624
  
    @m1r4ge, tested and confirm that this works. However, there is already a `nodeEqual` method
(see https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/plugman/util/plist-helpers.js#L83),
which compares nodes in a more correct way. Consider using it instead of string comparison.
    
    Also please file an Apache ICLA,  if possible (http://www.apache.org/dev/new-committers-guide.html#cla).
Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message