cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nikhilkh <...@git.apache.org>
Subject [GitHub] cordova-docs pull request: Adding linting, link verifier and slack...
Date Sun, 30 Aug 2015 06:04:18 GMT
Github user nikhilkh commented on a diff in the pull request:

    https://github.com/apache/cordova-docs/pull/323#discussion_r38268840
  
    --- Diff: gulpfile.js ---
    @@ -247,6 +250,23 @@ gulp.task("link-bugs", function (done) {
         exec(bin("linkify-bugs.sh"), [path.join(SOURCE_DIR, "_posts")], done);
     });
     
    +gulp.task('lint', function() {
    +    return gulp.src(path.join(LINT_DIR, "**", "*.html"))
    +        .pipe(htmllint());
    +});
    +
    +gulp.task('checklinks', function(cb) {
    +  crawler.crawl('http://localhost:3000/')
    --- End diff --
    
    This gulp task should depend on `serve` task. 
    Nit: Also, the URL should be set for browser-link and used here as a constant - or get
the default from browser-link if that's exposed instead of hardcoding this here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message