cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kamrik <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: Adds implementation for PlatformApiPoly ...
Date Mon, 24 Aug 2015 14:07:36 GMT
Github user kamrik commented on the pull request:

    https://github.com/apache/cordova-lib/pull/282#issuecomment-134217638
  
    Looks good! and very clean.
    
    One note about tests, jasmine spies seem to give you a lot of trouble. In the previous
refactoring round I was doing, I found it very useful to entirely replace some tests that
rely on spies too much with something based on filesystem fixtures with less spying.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message