cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From robpaveza <...@git.apache.org>
Subject [GitHub] cordova-ios pull request: CB-9512 Cordova-ios build/run should fai...
Date Wed, 19 Aug 2015 22:50:04 GMT
Github user robpaveza commented on a diff in the pull request:

    https://github.com/apache/cordova-ios/pull/154#discussion_r37478335
  
    --- Diff: bin/templates/scripts/cordova/run.bat ---
    @@ -15,11 +15,5 @@
     :: specific language governing permissions and limitations
     :: under the License
     @ECHO OFF
    -SET script_path="%~dp0run"
    -IF EXIST %script_path% (
    -        node %script_path% %*
    -) ELSE (
    -    ECHO.
    -    ECHO ERROR: Could not find 'run' script in 'cordova' folder, aborting...>&2
    -    EXIT /B 1
    -)
    +ECHO ERROR: Running 'ios' platform on Windows is not supported>&2
    +EXIT /B 0
    --- End diff --
    
    Why are you exiting with a success status?  The previous version exited with status code
1.  
    
    Probably should also change build.bat to return status code 1.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message