cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From muratsu <...@git.apache.org>
Subject [GitHub] cordova-windows pull request: CB-9499: There is a run failure when...
Date Mon, 17 Aug 2015 20:04:11 GMT
Github user muratsu commented on a diff in the pull request:

    https://github.com/apache/cordova-windows/pull/116#discussion_r37230334
  
    --- Diff: template/cordova/lib/package.js ---
    @@ -215,13 +215,20 @@ module.exports.deployToDesktop = function (package, deployTarget)
{
     
         return utils.getAppStoreUtils().then(function(appStoreUtils) {
             return getPackageName(path.join(__dirname, '..', '..')).then(function(pkgname)
{
    +
    +            var oldArch;
                 // uninstalls previous application instance (if exists)
                 console.log('Attempt to uninstall previous application version...');
                 return spawn('powershell', ['-ExecutionPolicy', 'RemoteSigned', 'Import-Module
"' + appStoreUtils + '"; Uninstall-App ' + pkgname])
                 .then(function() {
                     console.log('Attempt to install application...');
    +                oldArch = process.env.PROCESSOR_ARCHITECTURE;
    +                if (package.arch === 'x64') {
    +                    process.env.PROCESSOR_ARCHITECTURE = 'AMD64';
    +                }
                     return spawn('powershell', ['-ExecutionPolicy', 'RemoteSigned', 'Import-Module
"' + appStoreUtils + '"; Install-App', utils.quote(package.script)]);
    --- End diff --
    
    If we throw here the PROCESSOR_ARCHITECTURE will remain changed. While this currently
has no side effects, we probably want to have a catch promise and set the PROCESSOR_ARCHITECTURE
to the original value since it's a shared value. LGTM otherwise.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message