cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From omefire <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: Change cordova-lib to execute plugin hoo...
Date Sun, 16 Aug 2015 13:52:55 GMT
Github user omefire commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/236#discussion_r37146073
  
    --- Diff: cordova-lib/src/plugman/install.js ---
    @@ -357,7 +356,7 @@ function runInstall(actions, platform, project_dir, plugin_dir, plugins_dir,
opt
                         }
                     };
     
    -                var hooksRunner = new HooksRunner(projectRoot);
    +                var hooksRunner = new HooksRunner(cordovaUtil.isCordova() || project_dir);
     
    --- End diff --
    
    why `cordovaUtil.isCordova() || project_dir` ?
    wouldn't just using `project_dir` achieve the same result ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message