cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From robpaveza <...@git.apache.org>
Subject [GitHub] cordova-windows pull request: CB-9482: Upon further investigation ...
Date Wed, 12 Aug 2015 23:05:44 GMT
Github user robpaveza commented on a diff in the pull request:

    https://github.com/apache/cordova-windows/pull/113#discussion_r36925416
  
    --- Diff: template/cordova/lib/deployment.js ---
    @@ -35,7 +35,7 @@ function run(cmd, args, opt_cwd) {
             child.stderr.on('data', function(s) { stderr += s; });
             child.on('exit', function(code) {
                 if (code) {
    -                d.reject(stderr);
    +                d.reject({ message: stderr, code: code, toString: function() { return
stderr; }});
    --- End diff --
    
    This isn't logging.  This is providing an object instead of a string to the failure case
of a promise.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message