cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From stevengill <...@git.apache.org>
Subject [GitHub] cordova-js pull request: CB-9436 Refactor browserify to get rid of...
Date Tue, 04 Aug 2015 01:56:23 GMT
Github user stevengill commented on a diff in the pull request:

    https://github.com/apache/cordova-js/pull/124#discussion_r36151389
  
    --- Diff: tasks/lib/bundle-browserify.js ---
    @@ -19,53 +19,63 @@
     var fs           = require('fs');
     var path         = require('path');
     var browserify   = require('browserify');
    -var require_tr   = require('./require-tr');
     var root         = path.join(__dirname, '..', '..');
     var pkgJson      = require('../../package.json');
     var collectFiles = require('./collect-files');
     var copyProps    = require('./copy-props');
     
    -module.exports = function bundle(platform, debug, commitId, platformVersion) {
    -    require_tr.platform = platform;
    -    // FIXME: need to find a way to void ignore missing
    -    var b = browserify({debug: debug});
    -    // XXX plugin_list is not present at this stage 
    -    b.ignore(path.join(root, 'src', 'common', 'plugin_list'));
    +module.exports = function bundle(platform, debug, commitId, platformVersion, platformPath)
{
    +    platformPath = fs.existsSync(platformPath) && fs.existsSync(path.join(platformPath,
'cordova-js-src')) ?
    +        path.join(platformPath, 'cordova-js-src') :
    +        path.resolve(root, 'src', 'legacy-exec', platform);
     
    -    b.transform(require_tr.transform, {'platform': platform});
    +    var platformDirname = platform === 'amazon-fireos' ? 'android' : platform;
    --- End diff --
    
    hahaha smart


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message