cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From muratsu <...@git.apache.org>
Subject [GitHub] cordova-plugin-camera pull request: CB-9443 Pick correct maxResolu...
Date Mon, 03 Aug 2015 20:53:32 GMT
Github user muratsu commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-camera/pull/111#discussion_r36130273
  
    --- Diff: src/windows/CameraProxy.js ---
    @@ -696,21 +696,22 @@ function takePictureFromCameraWindows(successCallback, errorCallback,
args) {
         // decide which max pixels should be supported by targetWidth or targetHeight.
         var maxRes = null;
         var UIMaxRes = WMCapture.CameraCaptureUIMaxPhotoResolution;
    +    var totalPixels = targetWidth * targetHeight;
         switch (true) {
    --- End diff --
    
    didn't notice `switch (true)` was just correcting the case params but wow - haha. definetely
turning this to a `if/else`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message