cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From robpaveza <>
Subject [GitHub] cordova-plugin-camera pull request: CB-9443 Pick correct maxResolu...
Date Mon, 03 Aug 2015 20:49:51 GMT
Github user robpaveza commented on a diff in the pull request:
    --- Diff: src/windows/CameraProxy.js ---
    @@ -696,21 +696,22 @@ function takePictureFromCameraWindows(successCallback, errorCallback,
args) {
         // decide which max pixels should be supported by targetWidth or targetHeight.
         var maxRes = null;
         var UIMaxRes = WMCapture.CameraCaptureUIMaxPhotoResolution;
    +    var totalPixels = targetWidth * targetHeight;
         switch (true) {
    --- End diff --
    As long as you're refactoring the numbers, let's also turn this from `switch (true)` into

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message