Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
From: Mefire O. <ommenjik@microsoft.com>
To: "dev@cordova.apache.org" <dev@cordova.apache.org>
Subject: Re: Discuss Android plugin compatibility problem
Thread-Topic: Discuss Android plugin compatibility problem
Thread-Index: 
 AdC/1xq20sLW3+0uSfm9JLX+jkwsvAACy2SAAABy5AAAAFmOgAABLCQXAABOpYAAAGIzAAAWwGuAAAEb3gAAEUXFAAAD5mEAAAFmpuM=
Date: Fri, 17 Jul 2015 15:38:45 +0000
Message-ID: <cc5d6963-c122-416b-8267-d038588a3c74@email.android.com>
References: 
 <BL2PR03MB4179919B59B64D2B238A37B9E990@BL2PR03MB417.namprd03.prod.outlook.com>
 <CAHYtTqm=zq6SBuufTCyfGpT5zKJf49uNH=eQbZADSar6js51Jg@mail.gmail.com>
 <CAOBL_k4QL7exM5s278uOm+0+J9dOynzLEaz=vk=983fPRuxWNQ@mail.gmail.com>
 <CAHYtTq=bWa_JysRb-+VaR4D842_66tFVLv0x7nX1NgGJzUG3dg@mail.gmail.com>
 <233b92a0-7f34-46b0-80df-6839485f45c4@email.android.com>
 <CAMSbhBhY3f-nUjNssXSkS2Cq_MKHg2gdskgsUNdGmaQ9cdg=mg@mail.gmail.com>
 <CAOBL_k4_+J6gd8jbu4RwsTFbsrkz3YU3_9=6KQ8aLA0Hcs_4Xg@mail.gmail.com>
 <CAHYtTqk0urZ-Q0tuGFQTMXO=Wrtqf=q6Z9Zj4OXJMKan4m_OiA@mail.gmail.com>
 <CAOBL_k6pt547u+NoCz5aPeLBC9oXDuBb4P0MPng6g0zF=MtNFw@mail.gmail.com>
 <CAHYtTqnmSvKNM+8uAGV+dcc0bNpuVkQ+A-ZQ5YoEtSoNuggRcA@mail.gmail.com>,<CAOBL_k6vAii3q92ruO9qGrs3VS7GVbCoK=vaKu6rJrbp=v+DEA@mail.gmail.com>
In-Reply-To: 
 <CAOBL_k6vAii3q92ruO9qGrs3VS7GVbCoK=vaKu6rJrbp=v+DEA@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
by1pr03mb1387: X-MS-Exchange-Organization-RulesExecuted
Content-Type: multipart/alternative;
	boundary="_000_cc5d6963c122416b8267d038588a3c74emailandroidcom_"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Jul 2015 15:38:45.1171
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR03MB1387

--_000_cc5d6963c122416b8267d038588a3c74emailandroidcom_
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

So, it seems like mechanisms are already in place to enable us to do what w=
e wanna do here.

The actionable step I'm seeing here is 'updating the docs to ask plugin dev=
s to use plugin.xml to define gradle dependencies'.

If you folks agree with what this actionable item, I will create a jira ite=
m to track it.

Thanks,

On Jul 17, 2015 7:59 AM, Joe Bowser <bowserj@gmail.com> wrote:
I'm fine with it.  I just spaced out and forgot we did that for Crosswalk.
I thought we had a reference to a gradle file instead.

On Fri, Jul 17, 2015 at 6:14 AM Carlos Santana <csantana23@gmail.com> wrote=
:

> What's the problem Joe? Having declaring cradle dependencies in plugin.xm=
l
> I think is a good thing. At high level a plugin should be able to some ho=
w
> declare its dependencies for things located in gradle/maven via plugin.xm=
l,
> a metada file, or hook.
> We in IBM are using gradle in plugin.xml for some plugins we do, we want =
to
> do the same for iOS with cocoapods
>
> On Fri, Jul 17, 2015 at 12:53 AM Joe Bowser <bowserj@gmail.com> wrote:
>
> > Wait, yeah, plugin.xml does handle that.  I was thinking config.xml.
> WTF?
> >
> > On Thu, Jul 16, 2015 at 9:21 PM Carlos Santana <csantana23@gmail.com>
> > wrote:
> >
> > > Steve plugin.xml already supports declaring gradle deps
> > >
> > > On Thu, Jul 16, 2015 at 1:29 PM Joe Bowser <bowserj@gmail.com> wrote:
> > >
> > > > Ideally Maven should handle all this shit, and it should be
> invisible.
> > > Our
> > > > plugin system should not handle Java dependencies or any other
> platform
> > > > dependencies, and we should work behind the scenes to make this wor=
k
> > like
> > > > how Crosswalk works.
> > > >
> > > > On Thu, Jul 16, 2015 at 10:18 AM Steven Gill <stevengill97@gmail.co=
m
> >
> > > > wrote:
> > > >
> > > > > Would this be added to plugin.xml?
> > > > >
> > > > > On Thu, Jul 16, 2015 at 10:09 AM, Mefire O. <
> ommenjik@microsoft.com>
> > > > > wrote:
> > > > >
> > > > > > +1 on moving deps to gradle.
> > > > > >
> > > > > > On Jul 16, 2015 9:37 AM, Carlos Santana <csantana23@gmail.com>
> > > wrote:
> > > > > > you mean the scripts in cordova-android right? then yes
> > > > > >
> > > > > > +1 create jira bug, enhancements etc.. if doesn't get track it
> > > doesn't
> > > > > get
> > > > > > done
> > > > > >
> > > > > > On Thu, Jul 16, 2015 at 12:26 PM Joe Bowser <bowserj@gmail.com>
> > > wrote:
> > > > > >
> > > > > > > Is there a bug created for this? It sounds like we should hav=
e
> > the
> > > > > local
> > > > > > > scripts handle dependency adding on Android.
> > > > > > >
> > > > > > > On Thu, Jul 16, 2015 at 9:14 AM Carlos Santana <
> > > csantana23@gmail.com
> > > > >
> > > > > > > wrote:
> > > > > > >
> > > > > > > > +1 gradle declared dependencies only, cli to warn users abo=
ut
> > > > plugins
> > > > > > > > having libraries that will conflict, future is gradle no AN=
T
> > I'm
> > > ok
> > > > > to
> > > > > > > > start deprecating ant going forward.
> > > > > > > >
> > > > > > > >
> > > > > > > > On Thu, Jul 16, 2015 at 11:27 AM Sergey Grebnov (Akvelon) <
> > > > > > > > v-segreb@microsoft.com> wrote:
> > > > > > > >
> > > > > > > > > Hi guys, I want to raise the following question - what we
> > > should
> > > > > > > > > recommend  plugin developers to avoid 'Multiple dex files
> > > > defined'
> > > > > > > issue
> > > > > > > > on
> > > > > > > > > Android, for example [3]
> > > > > > > > >
> > > > > > > > > UNEXPECTED TOP-LEVEL EXCEPTION:
> > > > > > > > >         com.android.dex.DexException: Multiple dex files
> > define
> > > > > > > > >
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> Landroid/support/v4/accessibilityservice/AccessibilityServiceInfoCompat$A=
ccessibilityServiceInfoVersionImpl;
> > > > > > > > >
> > > > > > > > >
> > > > > > > > > To reproduce this problem you can add both Facebook [1] a=
nd
> > > > > > > PushPlugin[2]
> > > > > > > > > and then build android platform.
> > > > > > > > >
> > > > > > > > > This happens due to we still use jars to add plugin
> > > dependencies,
> > > > > but
> > > > > > > > > there are several very popular among them (like
> > > android-support,
> > > > > > gson)
> > > > > > > so
> > > > > > > > > we bring the same dependencies several times so build
> fails.
> > > > > > > > >
> > > > > > > > > I think we should start recommending people to start addi=
ng
> > > > > > > > > utility/common/popular dependencies via corresponding
> gradle
> > > > > > > > configuration
> > > > > > > > > (not using libs folder) as the only way to support multip=
le
> > > > plugins
> > > > > > > which
> > > > > > > > > could rely on the same dependency. In this case gradle wi=
ll
> > be
> > > > able
> > > > > > to
> > > > > > > > > handle this situation correctly using its smart Dependenc=
y
> > > > > > > > > Management/Versioning logic [4].
> > > > > > > > >
> > > > > > > > > For example,
> > > > > > > > >
> > > > > > > > > <source-file
> > > src=3D"src/android/com/plugin/android-support-v13.jar"
> > > > > > > > > target-dir=3D"libs/" />
> > > > > > > > > ->
> > > > > > > > > <framework src=3D"com.android.support:support-v13:21.0.0"=
 />
> > > > > > > > >
> > > > > > > > > Disadvantage of this approach is that Ant build won't be
> > > > supported
> > > > > (I
> > > > > > > > know
> > > > > > > > > some tricky/more complex way to correctly support both An=
t
> > and
> > > > > Gradle
> > > > > > > > but I
> > > > > > > > > don't think it is worth adding more complexity for plugin=
s
> > > > > developers
> > > > > > > > just
> > > > > > > > > to continue supporting Ant).
> > > > > > > > >
> > > > > > > > > Guys, any recommendations/thoughts how we should proceed =
in
> > > this
> > > > > > > > > situation? Maybe someone has better solution for this
> > problem?
> > > > > > > > >
> > > > > > > > > [1] https://github.com/Wizcorp/phonegap-facebook-plugin
> > > > > > > > > [2] https://github.com/phonegap-build/PushPlugin
> > > > > > > > > [3]
> > > > > https://github.com/Wizcorp/phonegap-facebook-plugin/issues/1028
> > > > > > > > > [4]
> > > > > > >
> > > https://docs.gradle.org/current/userguide/dependency_management.html
> > > > > > > > >
> > > > > > > > > Thx!
> > > > > > > > > Sergey
> > > > > > > > >
> > > > > > > > >
> > > > > > > > >
> > > > >
> ---------------------------------------------------------------------
> > > > > > > > > To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.or=
g
> > > > > > > > > For additional commands, e-mail:
> dev-help@cordova.apache.org
> > > > > > > > >
> > > > > > > > >
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>

--_000_cc5d6963c122416b8267d038588a3c74emailandroidcom_--