Return-Path: X-Original-To: apmail-cordova-dev-archive@www.apache.org Delivered-To: apmail-cordova-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 70BE018232 for ; Thu, 23 Jul 2015 17:27:28 +0000 (UTC) Received: (qmail 16586 invoked by uid 500); 23 Jul 2015 17:27:23 -0000 Delivered-To: apmail-cordova-dev-archive@cordova.apache.org Received: (qmail 16548 invoked by uid 500); 23 Jul 2015 17:27:23 -0000 Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cordova.apache.org Delivered-To: mailing list dev@cordova.apache.org Received: (qmail 16501 invoked by uid 99); 23 Jul 2015 17:27:22 -0000 Received: from Unknown (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 23 Jul 2015 17:27:22 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 82865D717B for ; Thu, 23 Jul 2015 17:27:22 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.9 X-Spam-Level: ** X-Spam-Status: No, score=2.9 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=3, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Authentication-Results: spamd1-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-us-west.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id Upi2Wurt1u9y for ; Thu, 23 Jul 2015 17:27:11 +0000 (UTC) Received: from mail-oi0-f53.google.com (mail-oi0-f53.google.com [209.85.218.53]) by mx1-us-west.apache.org (ASF Mail Server at mx1-us-west.apache.org) with ESMTPS id 1B00921048 for ; Thu, 23 Jul 2015 17:27:11 +0000 (UTC) Received: by oige126 with SMTP id e126so170645063oig.0 for ; Thu, 23 Jul 2015 10:26:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :content-type; bh=DaQqGe50L0j3ZDBewY2Nd+NwkDzuKP0FbDinBROsgDM=; b=mgQ+82BnXTBuSBlyU8TOEX6Q4YpVIec1BbGgUyTlNMRQWPMU5taWIXXsxtQ7FuH7Nz vfP/b8beCG1g1uvfBpHOm73K8AMLgIuNIG4hnursD/IFrqc0hsdDUt6dmpzjIf5vfdj1 qTuQlUkL3H67Hgmy7yss5J2PmLrhLM/syII7pFd0tuRYbBPOUdyZrCSYRIQc2ezgAuAz niM2ku0+svdqwrdGcrvroH6ivHHE+7t9Bz/aaSHUZYn5s0D6d59PwPEzrEohJUbFcBtx ZbA3gvSAKA0rHgUzQ9rTVafeWTtqVfeBcuEES+r5gS1CFsQDV4D3gCQVEPImGtQ4XeUj lTOQ== X-Received: by 10.60.103.107 with SMTP id fv11mr9949501oeb.16.1437672385490; Thu, 23 Jul 2015 10:26:25 -0700 (PDT) MIME-Version: 1.0 References: <0E1A9312-56A9-415C-B909-8D2C8B259FB4@gmail.com> In-Reply-To: <0E1A9312-56A9-415C-B909-8D2C8B259FB4@gmail.com> From: Victor Sosa Date: Thu, 23 Jul 2015 17:26:16 +0000 Message-ID: Subject: Re: Supported Git version To: "dev@cordova.apache.org" Content-Type: multipart/alternative; boundary=089e01160738d7581c051b8e2f09 --089e01160738d7581c051b8e2f09 Content-Type: text/plain; charset=UTF-8 Thanks a lot!! On Thu, Jul 23, 2015 at 12:23 PM Jesse wrote: > CB-9384 > https://github.com/apache/cordova-lib/pull/265 > > > > On Jul 23, 2015, at 10:10 AM, Victor Sosa > wrote: > > > > Now I understand. Thanks. > > Jesse, do you know the JIRA in which you worked this problem? > > > >> On Wed, Jul 22, 2015 at 5:27 PM Jesse wrote: > >> > >> Yes, we absolutely need to be able to install plugins via github url and > >> support branches/tags/commit-sha as part of the url. Also, sub-folders > >> within github repos. > >> > >> The feature I removed was the 'git version checking bs' [1] > >> > >> Carlos, npm supports installing from github too[2]. I'm not sure why > you > >> recommend dropping that as it is great for trying different combos. > >> ie. platformA+pluginB@unpublished-version. > >> > >> > >> [1] > >> > >> > https://github.com/apache/cordova-lib/commit/9af173a65281e9ea87fc6da3ee0b9f10bb8fec1c > >> [2] https://docs.npmjs.com/cli/install > >> > >> > >> > >> > >> > >> My team is hiring! > >> @purplecabbage > >> risingj.com > >> > >>> On Wed, Jul 22, 2015 at 3:00 PM, Darryl Pogue > wrote: > >>> > >>> Thanks for clarifying :) > >>> > >>>> On 22 July 2015 at 14:53, Steven Gill wrote: > >>>> > >>>> To clarify, we aren't removing installing from git. It is totally > >>>> important. > >>>> > >>>> Jesse fixed a problem with not being able to install from git when you > >>>> point to specific commit. This was do the --depth flag being used. He > >>>> recently removed the use of --depth and this may fix the git 1 vs 2 > >>> issues > >>>> Victor is seeing. > >>>> > >>>> On Wed, Jul 22, 2015 at 2:30 PM, Darryl Pogue > >> wrote: > >>>> > >>>>> Support for installing from git URLs for plugins is a pretty > >> important > >>>>> requirement for us as end users. > >>>>> > >>>>> On 22 July 2015 at 14:21, Carlos Santana > >> wrote: > >>>>> > >>>>>> +1 only npm id or local path should be supported > >>>>>> On Wed, Jul 22, 2015 at 5:16 PM Victor Sosa < > >> sosah.victor@gmail.com> > >>>>>> wrote: > >>>>>> > >>>>>>> Wait a minute, Jesse? what you mean by "I removed this > >> 'feature'"? > >>>> What > >>>>>>> feature are you referring to? > >>>>>>> > >>>>>>> On Wed, Jul 22, 2015 at 3:50 PM Jesse > >>>> wrote: > >>>>>>> > >>>>>>>> No idea, but, I just removed this 'feature' as there were > >> errors > >>>> with > >>>>>>>> checking out a particular tag or commit. > >>>>>>>> > >>>>>>>> > >>>>>>>> > >>>>>>>>> On Jul 22, 2015, at 1:29 PM, Victor Sosa < > >>> sosah.victor@gmail.com > >>>>> > >>>>>>> wrote: > >>>>>>>>> > >>>>>>>>> Hello community. > >>>>>>>>> > >>>>>>>>> I've been playing a little with Cordova on simple scenarios, > >>> and > >>>>>>> noticed > >>>>>>>>> that when using Git 2.x I get this error when installing a > >>> plugin > >>>>>> from > >>>>>>> a > >>>>>>>>> Git repo from GitHub > >>>>>>>>> https://github.com/apache/cordova-plugin-contacts.git > >>>>>>>>> > >>>>>>>>> The error is: > >>>>>>>>> *Error: git: Command failed with exit code 128 Error output:* > >>>>>>>>> *Cloning into '/tmp/git/1436905601736'...* > >>>>>>>>> *fatal: dumb http transport does not support --depth * > >>>>>>>>> > >>>>>>>>> However, when using 1.9.x I have no problems installing the > >>>> plugin. > >>>>>>>>> > >>>>>>>>> I've been looking at the docs but I can't find a single > >> mention > >>>> of > >>>>>>>>> supported Git version. Does anyone happen to know the answer > >> of > >>>>> this? > >>>>>>>>> > >>>>>>>>> BTW, using Cordova 5.1.1 > >>>> --------------------------------------------------------------------- > >>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org > >>>>>>>> For additional commands, e-mail: dev-help@cordova.apache.org > >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org > For additional commands, e-mail: dev-help@cordova.apache.org > > --089e01160738d7581c051b8e2f09--