Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
From: nikhilkh <git@git.apache.org>
To: dev@cordova.apache.org
Reply-To: dev@cordova.apache.org
References: <git-pr-102-cordova-windows@git.apache.org>
In-Reply-To: <git-pr-102-cordova-windows@git.apache.org>
Subject: [GitHub] cordova-windows pull request: CB-9359: Adds support for
 .appxbundl...
Content-Type: text/plain
Message-Id: <20150715222256.BC850E04EF@git1-us-west.apache.org>
Date: Wed, 15 Jul 2015 22:22:56 +0000 (UTC)

Github user nikhilkh commented on a diff in the pull request:

    https://github.com/apache/cordova-windows/pull/102#discussion_r34736868
  
    --- Diff: template/cordova/lib/MSBuildTools.js ---
    @@ -38,6 +38,13 @@ MSBuildTools.prototype.buildProject = function(projFile, buildType, buildarch) {
         '/p:Configuration=' + buildType,
         '/p:Platform=' + buildarch];
     
    +    if (otherConfigProperties) {
    --- End diff --
    
    This approach is not consistent with other ways we've done this in the code here. For packaging, we've leaned on generating a targets file every time we build. We should use that same mechanism here: https://github.com/apache/cordova-windows/blob/master/template/cordova/lib/prepare.js#L74
    
    Also, one of the downsides of this approach is that IDE <-> command line interop is broken. It's desirable for the IDE build to have the same results as the command line build. By adding an additional property at command line this can't be guaranteed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org