Return-Path: 
 <dev-return-47979-apmail-cordova-dev-archive=cordova.apache.org@cordova.apache.org>
X-Original-To: apmail-cordova-dev-archive@www.apache.org
Delivered-To: apmail-cordova-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 08BEB186ED
	for <apmail-cordova-dev-archive@www.apache.org>;
 Mon, 13 Jul 2015 05:43:50 +0000 (UTC)
Received: (qmail 35134 invoked by uid 500); 13 Jul 2015 05:43:49 -0000
Delivered-To: apmail-cordova-dev-archive@cordova.apache.org
Received: (qmail 35087 invoked by uid 500); 13 Jul 2015 05:43:49 -0000
Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@cordova.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@cordova.apache.org>
List-Post: <mailto:dev@cordova.apache.org>
List-Id: <dev.cordova.apache.org>
Reply-To: dev@cordova.apache.org
Delivered-To: mailing list dev@cordova.apache.org
Received: (qmail 35074 invoked by uid 99); 13 Jul 2015 05:43:49 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org)
 (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 13 Jul 2015 05:43:49 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at
 git1-us-west.apache.org, from userid 33)
	id 23CDBDFDE6; Mon, 13 Jul 2015 05:43:49 +0000 (UTC)
From: TimBarham <git@git.apache.org>
To: dev@cordova.apache.org
Reply-To: dev@cordova.apache.org
References: <git-pr-98-cordova-windows@git.apache.org>
In-Reply-To: <git-pr-98-cordova-windows@git.apache.org>
Subject: [GitHub] cordova-windows pull request: CB-9335: Windows
 quality-of-life imp...
Content-Type: text/plain
Message-Id: <20150713054349.23CDBDFDE6@git1-us-west.apache.org>
Date: Mon, 13 Jul 2015 05:43:49 +0000 (UTC)

Github user TimBarham commented on the pull request:

    https://github.com/apache/cordova-windows/pull/98#issuecomment-120820494
  
    Looks good to me.
    
    Have you verified no changes need to be made to `cordova-lib/src/util/windows/jsprojManager.js` (adding/removing plugins that use `<lib-file>` or `<framework>` elements for the windows platform)? Also, you might want to update `cordova-lib/spec-plugman/projects/windows/CordovaApp.sln` to reflect this change.
    
    Assuming that's all good, is this ready to be merged?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org