cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From scale-tone <...@git.apache.org>
Subject [GitHub] cordova-wp8 pull request: Get rid of Math.random() when making a r...
Date Sat, 18 Jul 2015 21:37:06 GMT
GitHub user scale-tone opened a pull request:

    https://github.com/apache/cordova-wp8/pull/86

    Get rid of Math.random() when making a request ID

    Math.random() takes several seconds to work (at least on my Lumia 820)! That's why, when
using AngularJS routing I experienced huge delays when loading partial views. This little
change fixed that.
    
    Can't file an issue in JIRA, because it fails to load in my browser. So just proposing
this pull request...

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/scale-tone/cordova-wp8 patch-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-wp8/pull/86.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #86
    
----
commit 5bb96ca4b40c655a1dfea073faf61b6e86f367c2
Author: Konstantin Lepeshenkov <konstantin.lepeshenkov@gmail.com>
Date:   2015-07-18T21:12:25Z

    Get rid of Math.random() when making a request ID
    
    Math.random() takes several seconds to work (at least on my Lumia 820)! That's why, when
using AngularJS routing I experienced huge delays when loading partial views. This little
change fixed that.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message