cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ghenry22 <...@git.apache.org>
Subject [GitHub] cordova-plugin-media pull request: More background threading for a...
Date Fri, 10 Jul 2015 01:04:49 GMT
GitHub user ghenry22 opened a pull request:

    https://github.com/apache/cordova-plugin-media/pull/61

    More background threading for audio

    send more functions to background threads.
    
    The previous submission fixes the UI blocking on load from URL with play(), xcode still
complains that other functions take too long and should use background threads even though
this is much less noticeable as the delays are far shorter than loading an entire audio file
from a URL they should still be backgrounded.
    
    this adds further backgrounding for most other playback methods.  I haven't changed record
as I have not been working with record and hence not been able to test.
    
    These changes work well on iphone5,6,ipad2 and the ios emulator and keep xcode happy.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ghenry22/cordova-plugin-media more-background-threading-for-audio

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-media/pull/61.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #61
    
----
commit afb82b4bb841258408242409adcfe77557888459
Author: ghenry22 <ghenry22@gmail.com>
Date:   2015-07-07T07:27:35Z

    Add background threading to play command

commit 10632de5bf55f3e4a9913193d8f06042b5c76e46
Author: ghenry22 <ghenry22@gmail.com>
Date:   2015-07-07T08:03:25Z

    Background other functions
    
    Stop / Pause / Seek were all showing warnings in xcode that they should
    use a background process so I have also wrapped those in a background
    process to stop them from blocking.

commit ce803907a9d9a8eea20312e0644b7d49ddc1e103
Author: ghenry22 <ghenry22@gmail.com>
Date:   2015-07-10T00:52:44Z

    more background
    
    xcode still complains about:
    create
    release
    setvolume
    
    pushed all to background threads to make xcode happy.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message