cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hstaudacher <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: restore-util.js can't handle git urls
Date Fri, 17 Jul 2015 07:35:57 GMT
GitHub user hstaudacher opened a pull request:

    https://github.com/apache/cordova-lib/pull/262

    restore-util.js can't handle git urls

    When adding a plugin to the config.xml using a git url e.g. <plugin name="https://..."
/> a spec is not needed because the plugin needs to be checked out by git. The restore-util.js
has a bug that uses the spec of a plugin when the spec is not valid. This does not make sense
because a) a spec without a name is not a valid plugin and b) a git url doe snot has a spec.
This commit changes the resture-util to use the pluginEntry.name instead of the spec if the
spec is not valid.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/hstaudacher/cordova-lib master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-lib/pull/262.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #262
    
----
commit 4b509f534da898145162a2b6a4fa0f591af5a8ce
Author: hstaudacher <hstaudacher@eclipsesource.com>
Date:   2015-07-17T07:32:18Z

    restore-util.js can't handle git urls
    
    When adding a plugin to the config.xml using a git url e.g. <plugin name="https://..."
/> a spec is not needed because the plugin needs to be checked out by git. The restore-util.js
has a bug that uses the spec of a plugin when the spec is not valid. This does not make sense
because a) a spec without a name is not a valid plugin and b) a git url doe snot has a spec.
This commit changes the resture-util to use the pluginEntry.name instead of the spec if the
spec is not valid.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message