cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mlegenhausen <...@git.apache.org>
Subject [GitHub] cordova-android pull request: cdvBuildMultipleApks casting fixed
Date Fri, 17 Jul 2015 13:51:25 GMT
GitHub user mlegenhausen opened a pull request:

    https://github.com/apache/cordova-android/pull/199

    cdvBuildMultipleApks casting fixed

    Casting `cdvBuildMultipleApks` via `!!` does not work when you want to modify the build
process via the command line. The problem can be simply reproduced when running: `cordova
build android -- --gradleArg=-PcdvBuildMultipleApks=false`. The expected output would be a
build with a single apk. But the result is a build with multiple apks cause `!!"false"` is
`true`. This fix solves the problem by using an more mature casting process that also can
handle string that contain the value `"false"`.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/werk85/cordova-android master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-android/pull/199.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #199
    
----
commit 9853a15163d3e4d47865ecb414e54844146f3d74
Author: Malte Legenhausen <mlegenhausen@gmail.com>
Date:   2015-07-17T13:51:10Z

    cdvBuildMultipleApks casting fixed
    
    Casting `cdvBuildMultipleApks` via `!!` does not work when you want to modify the build
process via the command line. The problem can be simply reproduced when running: `cordova
build android -- --gradleArg=-PcdvBuildMultipleApks=false`. The expected output would be a
build with a single apk. But the result is a build with multiple apks cause `!!"false"` is
`true`. This fix solves the problem by using an more mature casting process that also can
handle string that contain the value `"false"`.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message