cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dpolivy <...@git.apache.org>
Subject [GitHub] cordova-plugin-camera pull request: CB-9193: Add 'showLibraryButto...
Date Thu, 02 Jul 2015 23:36:03 GMT
GitHub user dpolivy opened a pull request:

    https://github.com/apache/cordova-plugin-camera/pull/104

    CB-9193: Add 'showLibraryButton' to allow choosing source

    A new camera option, `showLibraryButton`, is added which allows the user
    to easily switch from the camera to the photo library once they have
    entered the plugin.
    
    Currently, this is optimally supported on iOS (7+), with additional
    implementations for Android and WP8 based on what was available for
    those platforms. Please see the documentation updates (specifically, the 'Quirks' changes)
for details on how this is implemented on each platform.
    
    I realize that the behavior on Android and Windows Phone is not 100% consistent to iOS,
but it is the best that can be done given the constraints of what's available on those platforms.
If we were to rewrite this plugin to use completely custom camera UIs, we could do a whole
lot better -- but that's a much bigger undertaking.
    
    I also made some opportunistic changes while I was working on this, including cleaning
up parameter initialization for Android, moving hardcoded strings to localizable ones, fixing
some space/tab and indentation inconsistencies, and other code cleanup.
    
    All modifications here do not impact the default functionality of someone who is currently
using this plugin (though it would be great for additional test coverage on that). In order
for this change to work, `showLibraryButton: true` must be passed in the options, and the
source type must be `CAMERA`.
    
    @infil00p @shazron @nikhilkh @stevengill Is it possible to get reviews for your respective
platforms?
    
    Fixes https://issues.apache.org/jira/browse/CB-9193

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dpolivy/cordova-plugin-camera cb9193

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-camera/pull/104.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #104
    
----
commit c84b1f63a4fb8b51db78c2a735cb88a8c88b9b2f
Author: Dan Polivy <dan@cellartracker.com>
Date:   2015-06-17T22:55:20Z

    CB-9193: Add 'showLibraryButton' to allow choosing source
    
    A new camera option, showLibraryButton, is added which allows the user
    to easily switch from the camera to the photo library once they have
    entered the plugin.
    
    Currently, this is optimally supported on iOS (7+), with additional
    implementations for Android and WP8 based on what was available for
    those platforms.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message