cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From TimBarham <...@git.apache.org>
Subject [GitHub] cordova-plugin-device-motion pull request: CB-9426 Fix exception u...
Date Wed, 29 Jul 2015 23:41:30 GMT
Github user TimBarham commented on the pull request:

    https://github.com/apache/cordova-plugin-device-motion/pull/33#issuecomment-126129030
  
    I agree. My goal here however was just to fix the exception, not change the behavior of
a plugin I'm not familiar with :smile:... So what's the consensus - should I merge this change
now, or just leave it pendinging @purplecabbage's rewrite (same question applies to the `device-orientation`
change as well).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message