cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From purplecabbage <...@git.apache.org>
Subject [GitHub] cordova-plugin-device-motion pull request: CB-9426 Fix exception u...
Date Wed, 29 Jul 2015 14:47:08 GMT
Github user purplecabbage commented on the pull request:

    https://github.com/apache/cordova-plugin-device-motion/pull/33#issuecomment-125975741
  
    Yeah. I was still going to look at a rewrite in the near future. No need to fake data...
    
    
    
    > On Jul 29, 2015, at 6:38 AM, Vladimir Kotikov <notifications@github.com> wrote:
    > 
    > The PR LGTM.
    > 
    > However, IMO the code that emits devicemotion events might be removed due to:
    > a) this is not a scope of plugin to provide stubs for browser functionality
    > b) the devicemotion event is already supported by most of the browsers (http://caniuse.com/#search=devicemotion).
    > 
    > @purplecabbage, what do you think?
    > 
    > —
    > Reply to this email directly or view it on GitHub.
    > 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message