cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From purplecabbage <...@git.apache.org>
Subject [GitHub] cordova-plugin-device-motion pull request: CB-9426 Fix exception u...
Date Wed, 29 Jul 2015 00:54:46 GMT
Github user purplecabbage commented on the pull request:

    https://github.com/apache/cordova-plugin-device-motion/pull/33#issuecomment-125793282
  
    Actually, on second thought ...
    I don't think there is much reason for the browser implementation to have it's own version
of accelerometer.js This file is virtually identical to the one at www/accelerometer.js so
maybe it is time for a quick refactor.  
    
    Your understanding of merges and uniqueness of name are correct though. ;)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message