cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From TimBarham <...@git.apache.org>
Subject [GitHub] cordova-plugin-device-motion pull request: CB-9426 Fix exception u...
Date Wed, 29 Jul 2015 00:33:38 GMT
Github user TimBarham commented on the pull request:

    https://github.com/apache/cordova-plugin-device-motion/pull/33#issuecomment-125791006
  
    @stevengill and @purplecabbage - interested in whether this fix looks right to you guys,
since I've not worked in this code much before. Certainly after my change the functionality
seems correct - the `browser` specific module is a merge, with the same target that the general
module clobbers. Without my change, we don't get the merge. With my change, I verified we
do.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message