cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From purplecabbage <...@git.apache.org>
Subject [GitHub] cordova-plugin-file pull request: Make Android default persistent ...
Date Mon, 27 Jul 2015 21:39:23 GMT
Github user purplecabbage commented on the pull request:

    https://github.com/apache/cordova-plugin-file/pull/127#issuecomment-125350084
  
    This looks great to me!
    My only questions are, do we need a migration plugin?  or should this version include
migration code?
    
    Assuming android app users are running an older version which has placed some data on
their sdcard on a previous run.  Now all of their files would effectively disappear.
    
    We could mitigate this by using some sort of first run logic, which :
    
    a) checks if this plugin has been run before ( presumably by storing some hidden flag
on the file system )
    b) assuming a) is false, moves files (if present) from the old location to the new.
    c) sets a flag to pass the test in a)
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message