cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vladimir-kotikov <...@git.apache.org>
Subject [GitHub] cordova-windows pull request: CB-9235 Adds more checks based on th...
Date Wed, 22 Jul 2015 13:00:49 GMT
Github user vladimir-kotikov commented on the pull request:

    https://github.com/apache/cordova-windows/pull/92#issuecomment-123712167
  
    > When I run this branch on my local, I get an npm test failure for check_reqs.spec.js,
failing to find config.xml in cordova-windows root.
    
    Sorry, that was my bad. [Fixed this here](https://github.com/MSOpenTech/cordova-windows/commit/e3f4a7880bbc9a5c3af0f09637235d66fe6762ba#diff-f477d7d5a4a7b8cc0bfe70b71a81920fR71)
    
    > build.spec.js spec.13 fails because it doesn't mock findAllAvailableVersions
    
    I can't repro this. build specs are all passing on my local machine. Probably merge issues?
    
    > make sure your AppVeyor passes - I think it's a problem with check_reqs
    
    AppVeyor tests was failing because AppVeyor machines has UAC disabled (I already mentioned
that in one of my PRs, can't find it now), so the `run` command was failing. See https://github.com/apache/cordova-windows/blob/master/template/cordova/lib/run.js#L38.
I've updated `run` command and its tests, so this condition is now mocked, and tests are passing
even under the elevated prompt.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message