cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vladimir-kotikov <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: CB-9278: BugFix: Restoring multiple plat...
Date Wed, 22 Jul 2015 10:49:19 GMT
Github user vladimir-kotikov commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/266#discussion_r35200762
  
    --- Diff: cordova-lib/src/util/promise-util.js ---
    @@ -33,4 +33,21 @@ function Q_chainmap(args, func) {
         });
     }
     
    +// Behaves similar to Q_chainmap but gracefully handles failures.
    +// When a promise in the chain is rejected, it will call the failureCallback and then
continue the processing, instead of stopping
    --- End diff --
    
    Nit: The line is twice as longer than previous one. It might look better if split into
two lines.
    Another nit: Since this method is 'public', the comment might be rewritten using JSDoc
notation.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message