cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vladimir-kotikov <>
Subject [GitHub] cordova-lib pull request: CB-9278: BugFix: Restoring multiple plat...
Date Wed, 22 Jul 2015 10:45:48 GMT
Github user vladimir-kotikov commented on a diff in the pull request:
    --- Diff: cordova-lib/src/cordova/restore-util.js ---
    @@ -56,24 +57,23 @@ function installPlatformsFromConfigXML(platforms) {
         if (!targets || !targets.length) {
             return Q.all('No platforms are listed in config.xml to restore');
    -    // Run platform add for all the platforms seperately
    +    // Run `platform add` for all the platforms separately
         // so that failure on one does not affect the other.
    -    var promises = (target) {
    +    // CB-9278 : Run `platform add` serially, one platform after another
    +    // Otherwise, we get a bug where the following line:
    +    // gets executed simultaneously by each platform and leads to an exception being
    +    return promiseutil.Q_chainmap_graceful(targets, function(target) {
             if (target) {
    --- End diff --
    nit: I wonder if `target` can be falsy? Probably this condition is not required.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message