cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From omefire <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: CB-9384 Plugman should be able to checko...
Date Sat, 18 Jul 2015 18:58:24 GMT
Github user omefire commented on the pull request:

    https://github.com/apache/cordova-lib/pull/265#issuecomment-122580433
  
    @purplecabbage LGTM !
    But could you also add a comment to specify all the forms that 'git_ref' could assume
? (branch, commit SHA, etc...). That might prevent attempts at optimizations that will break
this scenario again.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message