cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From omefire <...@git.apache.org>
Subject [GitHub] cordova-android pull request: CB-9334 loop on CordovaPlugins befor...
Date Thu, 16 Jul 2015 06:52:53 GMT
Github user omefire commented on a diff in the pull request:

    https://github.com/apache/cordova-android/pull/195#discussion_r34760070
  
    --- Diff: framework/src/org/apache/cordova/PluginManager.java ---
    @@ -381,15 +374,16 @@ public void onReset() {
         }
     
         Uri remapUri(Uri uri) {
    +        Uri remap = uri;
             for (CordovaPlugin plugin : this.pluginMap.values()) {
                 if (plugin != null) {
    -                Uri ret = plugin.remapUri(uri);
    +                Uri ret = plugin.remapUri(remap);
                     if (ret != null) {
    -                    return ret;
    +                    remap = ret;
                     }
                 }
             }
    -        return null;
    +        return uri.equals(remap) ? null : remap;
    --- End diff --
    
    I suppose this returns null if no plugins ends up remapping the uri. However, a comment
as to why this is being done would be great !



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message