cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From robpaveza <...@git.apache.org>
Subject [GitHub] cordova-windows pull request: CB-9359: Adds support for .appxbundl...
Date Wed, 15 Jul 2015 23:22:35 GMT
Github user robpaveza commented on a diff in the pull request:

    https://github.com/apache/cordova-windows/pull/102#discussion_r34741242
  
    --- Diff: template/cordova/lib/MSBuildTools.js ---
    @@ -38,6 +38,13 @@ MSBuildTools.prototype.buildProject = function(projFile, buildType,
buildarch) {
         '/p:Configuration=' + buildType,
         '/p:Platform=' + buildarch];
     
    +    if (otherConfigProperties) {
    --- End diff --
    
    I'll look into the .targets approach.
    
    However, I don't agree with the IDE-CLI interop dichotomy.  In the IDE, you almost always
are building a single arch+mode target pair at a time (e.g., x86-debug).  In VS, you can generate
app package bundles, but you have to go through a particular menu to do so, not use the typical
MSBuild-invoking "Build" step workflow.  The same works here as well.
    
    The change was designed 100% to be just like the "Create App Packages" feature, just turned
on by default when building arch-specific packages.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message