cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nikhilkh <...@git.apache.org>
Subject [GitHub] cordova-js pull request: CB-9366 Log error.stack as it helps with ...
Date Wed, 15 Jul 2015 14:50:08 GMT
Github user nikhilkh commented on the pull request:

    https://github.com/apache/cordova-js/pull/118#issuecomment-121640154
  
    What's the downside of adding this? This is really an exceptional scenario and should
not hit commonly to clutter console log with ugly stack traces. Also, rethrowing the error
will reset it's stack property - depending on which runtime and platform you are using and
hence. window.onerror might not get the actual stack that caused the error.
    Putting it in console.log makes sure it shows in ADB logcat, Windows debug logs - hence,
it makes it easier for people to root cause such issues.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message