cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From robpaveza <...@git.apache.org>
Subject [GitHub] cordova-plugin-geolocation pull request: CB-9355 Fix Geolocation p...
Date Mon, 13 Jul 2015 16:11:33 GMT
Github user robpaveza commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-geolocation/pull/45#discussion_r34479900
  
    --- Diff: src/windows/GeolocationProxy.js ---
    @@ -142,8 +143,8 @@ module.exports = {
                     Windows.Devices.Geolocation.PositionAccuracy.high :
                     Windows.Devices.Geolocation.PositionAccuracy.default;
     
    -        if (cordova.platformId == 'windows' && WinJS.Utilities.isPhone) {
    -            // on Windows Phone 8.1 'positionchanged' event fails with error below if
movementThreshold is not set
    +        if (cordova.platformId == 'windows' && (WinJS.Utilities.isPhone || isWin10))
{
    +            // on Windows Phone 8.1 and Windows 10 'positionchanged' event fails with
error below if movementThreshold is not set
    --- End diff --
    
    We should just always set the movementThreshold property.  It exists for Windows 8 according
to the documentation.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message