cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From TimBarham <...@git.apache.org>
Subject [GitHub] cordova-windows pull request: CB-9335: Windows quality-of-life imp...
Date Mon, 13 Jul 2015 05:43:49 GMT
Github user TimBarham commented on the pull request:

    https://github.com/apache/cordova-windows/pull/98#issuecomment-120820494
  
    Looks good to me.
    
    Have you verified no changes need to be made to `cordova-lib/src/util/windows/jsprojManager.js`
(adding/removing plugins that use `<lib-file>` or `<framework>` elements for the
windows platform)? Also, you might want to update `cordova-lib/spec-plugman/projects/windows/CordovaApp.sln`
to reflect this change.
    
    Assuming that's all good, is this ready to be merged?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message