cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gillardo <...@git.apache.org>
Subject [GitHub] cordova-plugin-camera pull request: Focus control and nicer UI for...
Date Thu, 09 Jul 2015 18:43:21 GMT
Github user Gillardo commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-camera/pull/106#discussion_r34288832
  
    --- Diff: src/windows/CameraProxy.js ---
    @@ -370,10 +395,11 @@ function takePictureFromCameraWP(successCallback, errorCallback,
args) {
                 if (sensor !== null) {
                     sensor.addEventListener("orientationchanged", onOrientationChange);
                 }
    -            capturePreview.addEventListener('click', captureAction);
    +            //capturePreview.addEventListener('click', captureAction);
    --- End diff --
    
    I will do another commit for u. Probably tomorrow morning now.
    
    I am already signed up and sent my license off as contributed to other
    cordova plug in projects
    On 9 Jul 2015 7:41 pm, "Murat Sutunc" <notifications@github.com> wrote:
    
    > In src/windows/CameraProxy.js
    > <https://github.com/apache/cordova-plugin-camera/pull/106#discussion_r34288565>
    > :
    >
    > > @@ -370,10 +395,11 @@ function takePictureFromCameraWP(successCallback, errorCallback,
args) {
    > >              if (sensor !== null) {
    > >                  sensor.addEventListener("orientationchanged", onOrientationChange);
    > >              }
    > > -            capturePreview.addEventListener('click', captureAction);
    > > +            //capturePreview.addEventListener('click', captureAction);
    >
    > you can iterate with a new commit, I can merge them. Also before I can
    > merge your changes, you need to sign Apache's Contributor License Agreement
    > (can be done online): http://www.apache.org/licenses/#clas
    >
    > —
    > Reply to this email directly or view it on GitHub
    > <https://github.com/apache/cordova-plugin-camera/pull/106/files#r34288565>
    > .
    >



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message