cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From muratsu <...@git.apache.org>
Subject [GitHub] cordova-plugin-camera pull request: Focus control and nicer UI for...
Date Thu, 09 Jul 2015 18:41:18 GMT
Github user muratsu commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-camera/pull/106#discussion_r34288565
  
    --- Diff: src/windows/CameraProxy.js ---
    @@ -370,10 +395,11 @@ function takePictureFromCameraWP(successCallback, errorCallback,
args) {
                 if (sensor !== null) {
                     sensor.addEventListener("orientationchanged", onOrientationChange);
                 }
    -            capturePreview.addEventListener('click', captureAction);
    +            //capturePreview.addEventListener('click', captureAction);
    --- End diff --
    
    you can iterate with a new commit, I can merge them. Also before I can merge your changes,
you need to sign Apache's Contributor License Agreement (can be done online): http://www.apache.org/licenses/#clas


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message