cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From robpaveza <...@git.apache.org>
Subject [GitHub] cordova-windows pull request: CB-9283: Add support for Windows 10 ...
Date Wed, 08 Jul 2015 16:19:39 GMT
Github user robpaveza commented on a diff in the pull request:

    https://github.com/apache/cordova-windows/pull/96#discussion_r34167364
  
    --- Diff: template/cordova/lib/package.js ---
    @@ -113,16 +112,32 @@ function getPackageName(platformPath) {
     
     // returns one of available devices which name match with provided string
     // return rejected promise if device with name specified not found
    -module.exports.findDevice = function (target) {
    +module.exports.findDevice = function (deploymentTool, target) {
         target = target.toLowerCase();
    -    return module.exports.listDevices().then(function(deviceList) {
    +    return deploymentTool.enumerateDevices().then(function(deviceList) {
             // CB-7617 since we use partial match shorter names should go first,
             // example case is ['Emulator 8.1 WVGA 4 inch 512MB', 'Emulator 8.1 WVGA 4 inch']
    -        var sortedList = deviceList.concat().sort(function (l, r) { return l.length >
r.length; });
    -        for (var idx in sortedList){
    -            if (sortedList[idx].toLowerCase().indexOf(target) > -1) {
    -                // we should return index based on original list
    -                return Q.resolve(deviceList.indexOf(sortedList[idx]));
    +        // In CB-9283, we need to differentiate between emulator, device, and target.
    +        // So, for emulators to honor the above CB-7617, we preserve the original behavior.
    +        // Else, we choose either the target by ID (DeviceInfo.index) or if it's just
device,
    +        // we choose the default (aka first) device.
    +        if (target === 'emulator') {
    +            var sortedList = deviceList.concat().sort(function (l, r) { return l.toString().length
> r.toString().length; });
    --- End diff --
    
    Heh, that's ActionScript, but since it all comes from ES3 it's still true.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message