cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From robpaveza <>
Subject [GitHub] cordova-windows pull request: CB-9283: Add support for Windows 10 ...
Date Wed, 08 Jul 2015 00:16:21 GMT
Github user robpaveza commented on a diff in the pull request:
    --- Diff: template/cordova/lib/deployment.js ---
    @@ -0,0 +1,272 @@
    +       Licensed to the Apache Software Foundation (ASF) under one
    +       or more contributor license agreements.  See the NOTICE file
    +       distributed with this work for additional information
    +       regarding copyright ownership.  The ASF licenses this file
    +       to you under the Apache License, Version 2.0 (the
    +       "License"); you may not use this file except in compliance
    +       with the License.  You may obtain a copy of the License at
    +       Unless required by applicable law or agreed to in writing,
    +       software distributed under the License is distributed on an
    +       KIND, either express or implied.  See the License for the
    +       specific language governing permissions and limitations
    +       under the License.
    +var Q     = require('q'),
    +    fs    = require('fs'),
    +    /* jshint ignore:start */ // 'path' only used in ignored blocks 
    +    path  = require('path'),
    +    /* jshint ignore:end */
    +    proc  = require('child_process');
    +// neither 'exec' nor 'spawn' was sufficient because we need to pass arguments via spawn
    +// but also need to be able to capture stdout / stderr
    +function run(cmd, args, opt_cwd) {
    --- End diff --
    True.  We could create a separate jira (I don't want to dot out of cordova-windows to
access superspawn here) to do this refactor.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message