cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vladimir-kotikov <...@git.apache.org>
Subject [GitHub] cordova-windows pull request: CB-9235 Adds more checks based on th...
Date Tue, 07 Jul 2015 12:58:50 GMT
Github user vladimir-kotikov commented on a diff in the pull request:

    https://github.com/apache/cordova-windows/pull/92#discussion_r34035987
  
    --- Diff: bin/lib/check_reqs.js ---
    @@ -19,15 +19,226 @@
     
     /*jshint node:true*/
     
    -var Q     = require('Q');
    +var Q     = require('q');
    +var os    = require('os');
    +var path  = require('path');
    +var shell = require('shelljs');
     
    -var MSBuildTools;
    +var ConfigParser, MSBuildTools, Version, exec;
     try {
    +    ConfigParser = require('../../template/cordova/lib/ConfigParser');
         MSBuildTools = require('../../template/cordova/lib/MSBuildTools');
    +    exec = require('../../template/cordova/lib/exec');
    +    Version = require('../../template/cordova/lib/Version');
     } catch (ex) {
         // If previous import fails, we're probably running this script
         // from installed platform and the module location is different.
    +    ConfigParser = require('./ConfigParser');
         MSBuildTools = require('./MSBuildTools');
    +    exec = require('./exec');
    +    Version = require('./Version');
    +}
    +
    +// The constant for VS2013 Upd2 PackageVersion. See MSDN for
    +// reference: https://msdn.microsoft.com/en-us/library/bb164659(v=vs.120).aspx
    +var VS2013_UPDATE2_RC = new Version(12, 0, 30324);
    +var REQUIRED_VERSIONS = {
    +    '8.0': {
    +        os: '6.1',
    +        msbuild: '11.0',
    +        visualstudio: '11.0',
    +        windowssdk: '8.0'
    +    },
    +    '8.1': {
    +        os: '6.2',
    +        msbuild: '12.0',
    +        visualstudio: '12.0',
    +        windowssdk: '8.1',
    +        phonesdk: '8.1'
    +    },
    +    '10.0': {
    +        os: '6.2',
    --- End diff --
    
    I've realized that there is another mistake from my side: there should be something like:
    ```javascript
    '8.0': {
        os: '6.2', // instead of 6.1
        ...
    },
    '8.1': {
        os: '6.3', // instead of 6.2
        ...
    },
    '10.0': {
        os: '6.3', // Note that Windows 10 target is supported on Windows 7.
        ...        // This case get handled in checkOS function separately
        ...
    ``` 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message