cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From robpaveza <...@git.apache.org>
Subject [GitHub] cordova-medic pull request: CB-8936 Gathering logs on Windows
Date Mon, 06 Jul 2015 16:49:34 GMT
Github user robpaveza commented on a diff in the pull request:

    https://github.com/apache/cordova-medic/pull/58#discussion_r33955321
  
    --- Diff: medic/medic-run.js ---
    @@ -232,12 +233,18 @@ function windowsSpecificPreparation(argv) {
                 /^\s*\$appActivator .*$/gim,
                 "$&\n" +
                 "    powershell " + path.join(process.cwd(), destScriptPath) + " $$ID\n"
+
    +            "    powershell " + path.join(process.cwd(), logScriptPath) + "\n" +
                 "    $Ole32 = Add-Type -MemberDefinition '[DllImport(\"Ole32.dll\")]public
static extern int CoAllowSetForegroundWindow(IntPtr pUnk, IntPtr lpvReserved);' -Name 'Ole32'
-Namespace 'Win32' -PassThru\n" +
                 "    $Ole32::CoAllowSetForegroundWindow([System.Runtime.InteropServices.Marshal]::GetIUnknownForObject($appActivator),
[System.IntPtr]::Zero)",
                 appUtilsPath
             );
         }
     
    +    // write current time to a file to use it when gathering logs
    +    var now = new Date();
    +    var iso = now.toISOString();
    +    fs.writeFileSync('startTime.txt', iso, util.DEFAULT_ENCODING);
    --- End diff --
    
    Are we definitely writing to a file "startTime.txt"?  That seems like it'd be repeatedly
overwritten and we'd lose data.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message