cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From alsorokin <...@git.apache.org>
Subject [GitHub] cordova-android pull request: CB-9172 Improved emulator deploy sta...
Date Fri, 03 Jul 2015 06:44:01 GMT
Github user alsorokin commented on a diff in the pull request:

    https://github.com/apache/cordova-android/pull/188#discussion_r33843283
  
    --- Diff: bin/templates/cordova/lib/emulator.js ---
    @@ -238,13 +242,13 @@ module.exports.wait_for_emulator = function(num_running) {
      */
     module.exports.wait_for_boot = function(emulator_id) {
         var self = this;
    -    return exec('adb -s ' + emulator_id + ' shell getprop init.svc.bootanim', os.tmpdir())
    +    return exec('adb -s ' + emulator_id + ' shell ps', os.tmpdir())
         .then(function(output) {
    -        if (output.match(/stopped/)) {
    +        if (output.match(/android\.process\.acore/)) {
                 return;
             } else {
                 process.stdout.write('.');
    -            return Q.delay(3000).then(function() {
    +            return Q.delay(7000).then(function() {
    --- End diff --
    
    From my observations, `shell ps` (getting the list of all processes) is more time consuming
than `shell getprop` (getting one property) so I increased the polling time.
    This is only my feeling, we can safely return it back to 3s I think.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message