cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nikhilkh <...@git.apache.org>
Subject [GitHub] cordova-android pull request: CB-9172 Improved emulator deploy sta...
Date Fri, 03 Jul 2015 00:38:57 GMT
Github user nikhilkh commented on a diff in the pull request:

    https://github.com/apache/cordova-android/pull/188#discussion_r33834730
  
    --- Diff: bin/templates/cordova/lib/emulator.js ---
    @@ -238,13 +242,13 @@ module.exports.wait_for_emulator = function(num_running) {
      */
     module.exports.wait_for_boot = function(emulator_id) {
         var self = this;
    -    return exec('adb -s ' + emulator_id + ' shell getprop init.svc.bootanim', os.tmpdir())
    +    return exec('adb -s ' + emulator_id + ' shell ps', os.tmpdir())
         .then(function(output) {
    -        if (output.match(/stopped/)) {
    +        if (output.match(/android\.process\.acore/)) {
                 return;
             } else {
                 process.stdout.write('.');
    -            return Q.delay(3000).then(function() {
    +            return Q.delay(7000).then(function() {
    --- End diff --
    
    Wonder if doing this every 3 seconds might still be a good idea - why decrease this polling
frequency?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message