cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Rob Paveza <Rob.Pav...@microsoft.com>
Subject Re: JSHint breaks the build again
Date Tue, 21 Jul 2015 18:55:08 GMT
I would be OK with a style warning as long as the warning checks the contents of the string
for a single-quote, in which case it says, "Oh, you used double quotes so you could author
a single quote without an escape prefix!  I won't error you here."
________________________________________
From: Murat Sutunc <muratsu@microsoft.com>
Sent: Tuesday, July 21, 2015 11:34 AM
To: dev@cordova.apache.org
Subject: RE: JSHint breaks the build again

Yeah this rule is more of a style rule and doesn't check for language correctness. I'm ok
with removing it but I'm also wondering if we should separately have some sort of a style
checker (which will not block CI but give out warnings).

-----Original Message-----
From: Nikhil Khandelwal [mailto:nikhilkh@microsoft.com]
Sent: Tuesday, July 21, 2015 11:12 AM
To: dev@cordova.apache.org
Subject: RE: JSHint breaks the build again

I agree with your disagreement. :)

+1 to relaxing the condition.

Thanks,
Nikhil


-----Original Message-----
From: Jesse [mailto:purplecabbage@gmail.com]
Sent: Monday, July 20, 2015 6:00 PM
To: dev@cordova.apache.org
Subject: JSHint breaks the build again

I am sick of seeing my commits cause build CI failures because of single vs double quote use.
Can we relax this condition? I absolutely disagree with this being an error!

Cheers,
  Jesse

My team is hiring!
@purplecabbage
risingj.com

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
B�KKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKCB��[��X��ܚX�KK[XZ[�]�][��X��ܚX�P�ܙݘK�\X�K�ܙ�B��܈Y][ۘ[��[X[��K[XZ[�]�Z[�ܙݘK�\X�K�ܙ�B
Mime
View raw message