Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
From: TimBarham <git@git.apache.org>
To: dev@cordova.apache.org
Reply-To: dev@cordova.apache.org
References: <git-pr-93-cordova-windows@git.apache.org>
In-Reply-To: <git-pr-93-cordova-windows@git.apache.org>
Subject: [GitHub] cordova-windows pull request: CB-9252: Migrate WinJS to an
 NPM dep...
Content-Type: text/plain
Message-Id: <20150626163412.3D24AE01E2@git1-us-west.apache.org>
Date: Fri, 26 Jun 2015 16:34:12 +0000 (UTC)

Github user TimBarham commented on a diff in the pull request:

    https://github.com/apache/cordova-windows/pull/93#discussion_r33372216
  
    --- Diff: bin/lib/create.js ---
    @@ -98,6 +106,16 @@ module.exports.run = function (argv) {
         return Q.resolve();
     };
     
    +function recursiveCreateDirectory(targetPath) {
    +    var parent = path.join(targetPath, '..');
    +    if (!fs.existsSync(parent)) {
    +        recursiveCreateDirectory(parent);
    +    }
    +
    +    console.log('Creating directory "' + targetPath + '"');
    --- End diff --
    
    Heh... Do we really want to be notified about each directory we're creating in the path? If we need any notification, I'd prefer just a single one (so at the call point rather than here).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org