Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
From: TimBarham <git@git.apache.org>
To: dev@cordova.apache.org
Reply-To: dev@cordova.apache.org
References: <git-pr-238-cordova-lib@git.apache.org>
In-Reply-To: <git-pr-238-cordova-lib@git.apache.org>
Subject: [GitHub] cordova-lib pull request: CB-9127 Implements cordova-serve
 module.
Content-Type: text/plain
Message-Id: <20150609165821.93355DFF84@git1-us-west.apache.org>
Date: Tue,  9 Jun 2015 16:58:21 +0000 (UTC)

Github user TimBarham commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/238#discussion_r32036336
  
    --- Diff: cordova-serve/src/platform.js ---
    @@ -0,0 +1,55 @@
    +/**
    + Licensed to the Apache Software Foundation (ASF) under one
    + or more contributor license agreements.  See the NOTICE file
    + distributed with this work for additional information
    + regarding copyright ownership.  The ASF licenses this file
    + to you under the Apache License, Version 2.0 (the
    + "License"); you may not use this file except in compliance
    + with the License.  You may obtain a copy of the License at
    +
    + http://www.apache.org/licenses/LICENSE-2.0
    +
    + Unless required by applicable law or agreed to in writing,
    + software distributed under the License is distributed on an
    + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + KIND, either express or implied.  See the License for the
    + specific language governing permissions and limitations
    + under the License.
    + */
    +
    +var server = require('./server'),
    +    fs = require('fs'),
    +    util = require('./util');
    +
    +/**
    + * Launches a server where the root points to the specified platform in a Cordova project.
    + * @param {string} platform - Cordova platform to serve.
    + * @param {{root: ?string, port: ?number, urlPathProcessor: ?function, streamHandler: ?function, serverExtender: ?function}} opts
    + *   root - cordova project directory, or any directory within it. If not specified, cwd is used. This will be modified to point to the platform's www_dir.
    + *   All other values are passed unaltered to launchServer().
    + * @returns {*|promise}
    + */
    +module.exports = function (platform, opts) {
    +    if (!platform) {
    +        throw new Error('A platform must be specified');
    +    }
    +
    +    opts.root = util.getPlatformWwwRoot(findProjectRoot(opts.root), platform);
    --- End diff --
    
    Fixed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org