Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
From: TimBarham <git@git.apache.org>
To: dev@cordova.apache.org
Reply-To: dev@cordova.apache.org
References: <git-pr-238-cordova-lib@git.apache.org>
In-Reply-To: <git-pr-238-cordova-lib@git.apache.org>
Subject: [GitHub] cordova-lib pull request: CB-9127 Implements cordova-serve
 module.
Content-Type: text/plain
Message-Id: <20150609162015.96569DFF7C@git1-us-west.apache.org>
Date: Tue,  9 Jun 2015 16:20:15 +0000 (UTC)

Github user TimBarham commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/238#discussion_r32032171
  
    --- Diff: cordova-serve/src/server.js ---
    @@ -0,0 +1,137 @@
    +/**
    + Licensed to the Apache Software Foundation (ASF) under one
    + or more contributor license agreements.  See the NOTICE file
    + distributed with this work for additional information
    + regarding copyright ownership.  The ASF licenses this file
    + to you under the Apache License, Version 2.0 (the
    + "License"); you may not use this file except in compliance
    + with the License.  You may obtain a copy of the License at
    +
    + http://www.apache.org/licenses/LICENSE-2.0
    +
    + Unless required by applicable law or agreed to in writing,
    + software distributed under the License is distributed on an
    + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + KIND, either express or implied.  See the License for the
    + specific language governing permissions and limitations
    + under the License.
    + */
    +
    +var fs     = require('fs'),
    +    http   = require('http'),
    +    url    = require('url'),
    +    path   = require('path'),
    +    Q      = require('q'),
    +    stream = require('./stream');
    +
    +/**
    + * @desc Launches a server with the specified options and optional custom handlers.
    + * @param {{root: ?string, port: ?number, urlPathProcessor: ?function, streamHandler: ?function, serverExtender: ?function}} opts
    + * @returns {*|promise}
    + */
    +module.exports = function (opts) {
    +    var deferred = Q.defer();
    +
    +    var root = opts.root;
    +    var port = opts.port || 8000;
    +
    +    var server = http.createServer(function (request, response) {
    +        function do404() {
    +            console.log('404 ' + request.url);
    +            response.writeHead(404, {'Content-Type': 'text/plain'});
    +            response.write('404 Not Found\n');
    +            response.end();
    +        }
    +
    +        function do302(where) {
    +            console.log('302 ' + request.url);
    +            response.setHeader('Location', where);
    +            response.writeHead(302, {'Content-Type': 'text/plain'});
    +            response.end();
    +        }
    +
    +        function do304() {
    +            console.log('304 ' + request.url);
    +            response.writeHead(304, {'Content-Type': 'text/plain'});
    +            response.end();
    +        }
    +
    +        function isFileChanged(path) {
    +            var mtime = fs.statSync(path).mtime,
    +                itime = request.headers['if-modified-since'];
    +            return !itime || new Date(mtime) > new Date(itime);
    +        }
    +
    +        var urlPath = url.parse(request.url).pathname;
    +
    +        var filePath;
    +        if (opts.urlPathProcessor) {
    +            var result = opts.urlPathProcessor(urlPath, request, response, do302, do404);
    +            if (!result) {
    +                return;
    +            }
    +            filePath = result.filePath;
    +        }
    +        if (!filePath) {
    +            if (!root) {
    +                throw new Error('No server root directory HAS BEEN specified!');
    +            }
    +            filePath = path.join(root, urlPath);
    +        }
    +
    +        fs.exists(filePath, function (exists) {
    +            if (!exists) {
    +                do404();
    +                return;
    +            }
    +            if (fs.statSync(filePath).isDirectory()) {
    +                var index = path.join(filePath, 'index.html');
    +                try {
    +                    if (fs.statSync(index)) {
    +                        filePath = index;
    +                    }
    +                } catch (e) {
    +                }
    +            }
    +            if (fs.statSync(filePath).isDirectory()) {
    +                if (!/\/$/.test(urlPath)) {
    +                    do302(request.url + '/');
    +                    return;
    +                }
    +                console.log('200 ' + request.url);
    +                response.writeHead(200, {'Content-Type': 'text/html'});
    +                response.write('<html><head><title>Directory listing of ' + urlPath + '</title></head>');
    +                response.write('<h3>Items in this directory</h3>');
    +                response.write('<ul>');
    +                fs.readdirSync(filePath).forEach(function (file) {
    +                    if (file) {
    +                        response.write('<li><a href="' + file + '">' + file + '</a></li>\n');
    +                    }
    +                });
    +
    +                response.write('</ul>');
    +                response.end();
    +            } else if (!isFileChanged(filePath)) {
    +                do304();
    +            } else {
    +                (opts.streamHandler && opts.streamHandler(filePath, request, response)) || stream(filePath, request, response);
    --- End diff --
    
    Hah, fair point. Though I'm tempted to make it:
    
        (opts.streamHandler || stream)(filePath, request, response);
    
    Jut for kicks :smile: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org