Return-Path: X-Original-To: apmail-cordova-dev-archive@www.apache.org Delivered-To: apmail-cordova-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id AE28718A9B for ; Fri, 5 Jun 2015 17:49:15 +0000 (UTC) Received: (qmail 58768 invoked by uid 500); 5 Jun 2015 17:49:15 -0000 Delivered-To: apmail-cordova-dev-archive@cordova.apache.org Received: (qmail 58727 invoked by uid 500); 5 Jun 2015 17:49:15 -0000 Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cordova.apache.org Delivered-To: mailing list dev@cordova.apache.org Received: (qmail 58716 invoked by uid 99); 5 Jun 2015 17:49:15 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 05 Jun 2015 17:49:15 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 0EC34E0519; Fri, 5 Jun 2015 17:49:15 +0000 (UTC) From: TimBarham To: dev@cordova.apache.org Reply-To: dev@cordova.apache.org References: In-Reply-To: Subject: [GitHub] cordova-lib pull request: CB-9033 : fix WatchKit support Content-Type: text/plain Message-Id: <20150605174915.0EC34E0519@git1-us-west.apache.org> Date: Fri, 5 Jun 2015 17:49:15 +0000 (UTC) Github user TimBarham commented on the pull request: https://github.com/apache/cordova-lib/pull/219#issuecomment-109377681 It's certainly a common JavaScript recommendation to always use strict equality / inequality operators so you don't accidentally get an invalid match because of type conversion. It can also be much faster (because no type conversion), though that is unlikely to be significant in most of the stuff we do. So it can be a good habit to form, but in this particular scenario I can't see it making a difference. Ultimately as long as we're *intentional* about which we use in each situation, all is good (personally my approach is to always use the strict operators unless I have a specific, intentional reason not to). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org For additional commands, e-mail: dev-help@cordova.apache.org