Return-Path: X-Original-To: apmail-cordova-dev-archive@www.apache.org Delivered-To: apmail-cordova-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 69E2D10011 for ; Wed, 3 Jun 2015 01:05:54 +0000 (UTC) Received: (qmail 60412 invoked by uid 500); 3 Jun 2015 01:05:54 -0000 Delivered-To: apmail-cordova-dev-archive@cordova.apache.org Received: (qmail 60368 invoked by uid 500); 3 Jun 2015 01:05:54 -0000 Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cordova.apache.org Delivered-To: mailing list dev@cordova.apache.org Received: (qmail 60345 invoked by uid 99); 3 Jun 2015 01:05:53 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Jun 2015 01:05:53 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id B917FDFFD5; Wed, 3 Jun 2015 01:05:53 +0000 (UTC) From: omefire To: dev@cordova.apache.org Reply-To: dev@cordova.apache.org References: In-Reply-To: Subject: [GitHub] cordova-lib pull request: CB-9108 Handle version ranges when add p... Content-Type: text/plain Message-Id: <20150603010553.B917FDFFD5@git1-us-west.apache.org> Date: Wed, 3 Jun 2015 01:05:53 +0000 (UTC) Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/232#issuecomment-108146590 I spent some time reviewing this, it looks good to me even though I think the --usegit flag should be eliminated (some time in the future) now that we have the capability to add platforms using git-urls : `cordova platform add https://github.com/apache/cordova-android.git` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org For additional commands, e-mail: dev-help@cordova.apache.org