cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From TimBarham <...@git.apache.org>
Subject [GitHub] cordova-coho pull request: Initial coho handling for the new cordo...
Date Wed, 10 Jun 2015 18:38:14 GMT
GitHub user TimBarham opened a pull request:

    https://github.com/apache/cordova-coho/pull/84

    Initial coho handling for the new cordova-serve module in cordova-lib.

    1. Adds `cordova-serve` as another "repo" in coho's list of repos (it actually just points
to the `cordova-lib` repo, but allows various command to work directly on `cordova-serve`).
    2. Adds the ability to work with prefixed tags, so `cordova-serve` can maintain versions
independent of `cordova-lib`.
    
    Note that this introduces `cordova-serve` as another "repo" as far as coho is concerned,
which I think works ok for now. But ultimately, particularly if we introduce more modules
in the `cordova-lib` repo, we should probably add to coho the concept of "modules" or "packages"
within repos (so `cordova-serve` would not exist as a separate "repo" in coho's list of repos,
but as a module within the `cordova-lib` repo, alongside the `cordova-lib` module) - then,
among other benefits, we can provide generic handling for the fact that modules live within
sub-directories of their repo (rather than the custom handling we have now).

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/MSOpenTech/cordova-coho tb-handle-serve

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-coho/pull/84.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #84
    
----
commit 6735cdf76b073e6ecaf9154e8730c57e927e6a46
Author: Tim Barham <tim.barham@microsoft.com>
Date:   2015-06-10T18:22:22Z

    Initial handling for the new cordova-serve module in cordova-lib.
    
    1. Adds cordova-serve as another 'repo' (which is really pointing to the cordova-lib repo).
    2. Adds the ability to work with prefixed tags, so cordova-serve can maintain versions
independent of cordova-lib.
    
    Note that this introduces cordova-serve as another repo as far as COHO is concerned. This
works ok for now, but ultimately if we introduce more modules in the cordova-lib repo we should
probably add the concept of modules or packages to repos (so cordova-serve would not exist
as a 'repo' in COHO, but as a module within the cordova-lib repo) - then. among other benefits,
we won't need custom handling for the fact that cordova-lib and cordova-serve live within
subdirectories of their repo.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message