cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aroberson <...@git.apache.org>
Subject [GitHub] cordova-plugin-media-capture pull request: Various Fixes to crashe...
Date Thu, 04 Jun 2015 19:06:53 GMT
GitHub user aroberson opened a pull request:

    https://github.com/apache/cordova-plugin-media-capture/pull/38

    Various Fixes to crashes in Windows Phone 8

    This pull request contains the following fixes.
    
    1.  The app crashes in wp8 when trying to take a picture or video and use the back arrow
key.  This is fixed by checking for defined file object before processing it.
    2.  The app crashes in wp8 when using gestures on the capture picture or capture video
screens.  The solution is to not use the click event and move to the MSGestures events for
gestures.  This change replaces the onclick event with listening for MSGestureTap event.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ABB-Austin/cordova-plugin-media-capture master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-media-capture/pull/38.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #38
    
----
commit 600afcab6c82819d5b065311054eea9c95dd4adf
Author: aroberson <adam.roberson@ventyx.abb.com>
Date:   2015-05-19T16:14:15Z

    Fixed cancel of image capture to return no media

commit acf815e6faa9c460c0b89fc05731b33811139f42
Author: aroberson <adam.roberson@ventyx.abb.com>
Date:   2015-05-19T16:16:13Z

    remove dependency

commit 18b3a8cfba95e9f2e533898d3fc116ddd5c7f3a8
Author: aroberson <adam.roberson@ventyx.abb.com>
Date:   2015-05-19T16:19:38Z

    Remove file dependency

commit 7af759049eaf34958f852d9ed20d9dda1c7a61ca
Author: aroberson <adam.roberson@ventyx.abb.com>
Date:   2015-05-19T16:35:57Z

    Added back dependency

commit 13a60dd6cd48b1e477023268b5351434282357c1
Author: aroberson <adam.roberson@ventyx.abb.com>
Date:   2015-05-20T19:57:16Z

    Added catch error function for unsupported actions.

commit cb19f02d048f9bff131e51671314fdc9b3dac06c
Author: aroberson <adam.roberson@ventyx.abb.com>
Date:   2015-06-01T18:12:41Z

    Catch exceptions caused by zoom events

commit 3d0af79944df315ff6d3318e773f44319b9ae3c1
Author: aroberson <adam.roberson@ventyx.abb.com>
Date:   2015-06-04T16:28:56Z

    Removed the on click for camera preview and replaced with gesture tracking.

commit 77b01c564989862f127b6f93411cba59add9ae29
Author: aroberson <adam.roberson@ventyx.abb.com>
Date:   2015-06-04T18:41:26Z

    Fixed Tap Gesture processing for ui

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message